Re: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-26 Thread Peter Maydell
On Mon, 26 Nov 2018 at 12:52, Edgar E. Iglesias wrote: > > On Fri, Nov 23, 2018 at 05:09:35PM +, Peter Maydell wrote: > > On Fri, 23 Nov 2018 at 16:59, Edgar E. Iglesias > > wrote: > > > Not sure if it's too late to even get the removal of the assert into this > > > release? Peter? > > > > I

Re: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-26 Thread Edgar E. Iglesias
On Fri, Nov 23, 2018 at 05:09:35PM +, Peter Maydell wrote: > On Fri, 23 Nov 2018 at 16:59, Edgar E. Iglesias > wrote: > > Not sure if it's too late to even get the removal of the assert into this > > release? Peter? > > If you're happy that removing the assert is the correct fix, > yes, this

Re: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-23 Thread Philippe Mathieu-Daudé
On 23/11/18 18:06, Edgar E. Iglesias wrote: > On Fri, Nov 23, 2018 at 06:02:25PM +0100, Edgar E. Iglesias wrote: >> On Fri, Nov 23, 2018 at 05:59:45PM +0100, Edgar E. Iglesias wrote: >>> On Fri, Nov 23, 2018 at 05:46:17PM +0100, Philippe Mathieu-Daudé wrote: Hi Edgar, >>> >>> Hi Philippe, >>>

Re: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-23 Thread Edgar E. Iglesias
On Fri, Nov 23, 2018 at 06:02:25PM +0100, Edgar E. Iglesias wrote: > On Fri, Nov 23, 2018 at 05:59:45PM +0100, Edgar E. Iglesias wrote: > > On Fri, Nov 23, 2018 at 05:46:17PM +0100, Philippe Mathieu-Daudé wrote: > > > Hi Edgar, > > > > Hi Philippe, > > > > > > > > On 23/11/18 14:54, Edgar E. Igl

Re: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-23 Thread Edgar E. Iglesias
On Fri, Nov 23, 2018 at 05:59:45PM +0100, Edgar E. Iglesias wrote: > On Fri, Nov 23, 2018 at 05:46:17PM +0100, Philippe Mathieu-Daudé wrote: > > Hi Edgar, > > Hi Philippe, > > > > > On 23/11/18 14:54, Edgar E. Iglesias wrote: > > > From: "Edgar E. Iglesias" > > > > > > Don't assert on RX descr

Re: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-23 Thread Peter Maydell
On Fri, 23 Nov 2018 at 16:59, Edgar E. Iglesias wrote: > Not sure if it's too late to even get the removal of the assert into this > release? Peter? If you're happy that removing the assert is the correct fix, yes, this could go in before rc3 next week. thanks -- PMM

Re: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-23 Thread Edgar E. Iglesias
On Fri, Nov 23, 2018 at 05:46:17PM +0100, Philippe Mathieu-Daudé wrote: > Hi Edgar, Hi Philippe, > > On 23/11/18 14:54, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Don't assert on RX descriptor settings when the receiver is > > disabled. This fixes an issue with incoming pac

Re: [Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-23 Thread Philippe Mathieu-Daudé
Hi Edgar, On 23/11/18 14:54, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Don't assert on RX descriptor settings when the receiver is > disabled. This fixes an issue with incoming packets on an > unused GEM. > > Reported-by: mbilal > Signed-off-by: Edgar E. Iglesias > --- > hw/ne

[Qemu-devel] [PATCH v1 1/1] net: cadence_gem: Remove incorrect assert()

2018-11-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Don't assert on RX descriptor settings when the receiver is disabled. This fixes an issue with incoming packets on an unused GEM. Reported-by: mbilal Signed-off-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/c