Hi Edgar,
On 23/11/18 14:54, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <[email protected]>
>
> Don't assert on RX descriptor settings when the receiver is
> disabled. This fixes an issue with incoming packets on an
> unused GEM.
>
> Reported-by: mbilal <[email protected]>
> Signed-off-by: Edgar E. Iglesias <[email protected]>
> ---
> hw/net/cadence_gem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index d95cc27f58..7f63411430 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -979,7 +979,6 @@ static ssize_t gem_receive(NetClientState *nc, const
> uint8_t *buf, size_t size)
>
> /* Do nothing if receive is not enabled. */
> if (!gem_can_receive(nc)) {
> - assert(!first_desc);
Maybe worth:
trace_gem_receive_packet_drop(size);
> return -1;
Shouldn't this be 'return 0'?
The "net/net.h" doc is scarce...
Regards,
Phil.
> }
>
>
