Re: [Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence for SUNW, fdtwo

2013-07-29 Thread Andreas Färber
Am 29.07.2013 13:55, schrieb Mark Cave-Ayland: > On 27/07/13 02:50, Andreas Färber wrote: > >> Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's >> initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539) >> was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather th

Re: [Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence for SUNW, fdtwo

2013-07-29 Thread Mark Cave-Ayland
On 27/07/13 02:50, Andreas Färber wrote: Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539) was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than SUNW,fdtwo. Fix this by letting SUNW,fdtwo and sysbus-

Re: [Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence for SUNW, fdtwo

2013-07-26 Thread Andreas Färber
Am 27.07.2013 03:50, schrieb Andreas Färber: > Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's > initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539) > was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than > SUNW,fdtwo. > > Fix this by letting SUNW,fdtw

[Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence for SUNW, fdtwo

2013-07-26 Thread Andreas Färber
Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539) was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than SUNW,fdtwo. Fix this by letting SUNW,fdtwo and sysbus-fdc both inherit from an abstract type base-