Am 29.07.2013 13:55, schrieb Mark Cave-Ayland: > On 27/07/13 02:50, Andreas Färber wrote: > >> Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's >> initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539) >> was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than >> SUNW,fdtwo. >> >> Fix this by letting SUNW,fdtwo and sysbus-fdc both inherit from an >> abstract type base-sysbus-fdc. >> >> This allows to consolidate realizefns by using instance_init functions. >> Clean up variable names and variable order while at it. >> >> Reported-by: Mark Cave-Ayland<[email protected]> >> Cc: Hu Tao<[email protected]> >> Signed-off-by: Andreas Färber<[email protected]> > > Hi Andreas, > > I can confirm that this fixes SPARC32 for me - thanks! > > Tested-by: Mark Cave-Ayland <[email protected]>
Thanks. Can you give my latest qom-devices branch a whirl, too? I started adding trivial qtests for machines, but only covering the default machines without -fda etc. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
