Re: [Qemu-devel] [PATCH for 2.1] vfio: use correct runstate

2014-07-02 Thread Eric Blake
[adding libvirt] On 06/27/2014 11:51 AM, Paolo Bonzini wrote: > - Messaggio originale - >> Da: "Alex Williamson" >> A: "Paolo Bonzini" >> Cc: qemu-devel@nongnu.org, qemu-triv...@nongnu.org >> Inviato: Venerdì, 27 giugno 2014 18:34:59 >> Oggetto: Re: [PATCH for 2.1] vfio: use correct runs

Re: [Qemu-devel] [PATCH for 2.1] vfio: use correct runstate

2014-06-27 Thread Alex Williamson
On Fri, 2014-06-27 at 13:51 -0400, Paolo Bonzini wrote: > - Messaggio originale - > > Da: "Alex Williamson" > > A: "Paolo Bonzini" > > Cc: qemu-devel@nongnu.org, qemu-triv...@nongnu.org > > Inviato: Venerdì, 27 giugno 2014 18:34:59 > > Oggetto: Re: [PATCH for 2.1] vfio: use correct runsta

Re: [Qemu-devel] [PATCH for 2.1] vfio: use correct runstate

2014-06-27 Thread Paolo Bonzini
- Messaggio originale - > Da: "Alex Williamson" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, qemu-triv...@nongnu.org > Inviato: Venerdì, 27 giugno 2014 18:34:59 > Oggetto: Re: [PATCH for 2.1] vfio: use correct runstate > > On Fri, 2014-06-27 at 16:32 +0200, Paolo Bonzini wrote: > >

Re: [Qemu-devel] [PATCH for 2.1] vfio: use correct runstate

2014-06-27 Thread Alex Williamson
On Fri, 2014-06-27 at 16:32 +0200, Paolo Bonzini wrote: > io-error is for block device errors; it should always be preceded > by a BLOCK_IO_ERROR event. Where does this requirement come from? I only see a loose association of IO_ERROR to disk in libvirt and none in QEMU. > I think vfio wants t

[Qemu-devel] [PATCH for 2.1] vfio: use correct runstate

2014-06-27 Thread Paolo Bonzini
io-error is for block device errors; it should always be preceded by a BLOCK_IO_ERROR event. I think vfio wants to use RUN_STATE_INTERNAL_ERROR instead. Cc: Alex Williamson Signed-off-by: Paolo Bonzini --- hw/misc/vfio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mi