On Fri, 2014-06-27 at 16:32 +0200, Paolo Bonzini wrote: > io-error is for block device errors; it should always be preceded > by a BLOCK_IO_ERROR event.
Where does this requirement come from? I only see a loose association of IO_ERROR to disk in libvirt and none in QEMU. > I think vfio wants to use > RUN_STATE_INTERNAL_ERROR instead. But that seems to put us into an "unknown" paused state in libvirt. An I/O error still seems like a more appropriate state. I'm not sure this qualifies as a trivial patch, it is small, but subtle. Thanks, Alex > > Cc: Alex Williamson <[email protected]> > Signed-off-by: Paolo Bonzini <[email protected]> > --- > hw/misc/vfio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c > index 7437c2e..9d71d97 100644 > --- a/hw/misc/vfio.c > +++ b/hw/misc/vfio.c > @@ -3978,7 +3978,7 @@ static void vfio_err_notifier_handler(void *opaque) > __func__, vdev->host.domain, vdev->host.bus, > vdev->host.slot, vdev->host.function); > > - vm_stop(RUN_STATE_IO_ERROR); > + vm_stop(RUN_STATE_INTERNAL_ERROR); > } > > /*
