Re: [Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error handling

2013-08-05 Thread Jan Kiszka
On 2013-08-05 14:06, Andreas Färber wrote: > Am 02.08.2013 19:22, schrieb Andreas Färber: >> Error **errp argument is not for emitting warnings, it means an error >> has occurred and the caller should not make any assumptions about the >> state of other return values (unless otherwise documented).

Re: [Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error handling

2013-08-05 Thread Andreas Färber
Am 02.08.2013 19:22, schrieb Andreas Färber: > Error **errp argument is not for emitting warnings, it means an error > has occurred and the caller should not make any assumptions about the > state of other return values (unless otherwise documented). > > Therefore cpu_x86_create() must unref the n

[Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error handling

2013-08-02 Thread Andreas Färber
Error **errp argument is not for emitting warnings, it means an error has occurred and the caller should not make any assumptions about the state of other return values (unless otherwise documented). Therefore cpu_x86_create() must unref the new X86CPU itself, and pc_new_cpu() must check for an Er