Am 02.08.2013 19:22, schrieb Andreas Färber: > Error **errp argument is not for emitting warnings, it means an error > has occurred and the caller should not make any assumptions about the > state of other return values (unless otherwise documented). > > Therefore cpu_x86_create() must unref the new X86CPU itself, and > pc_new_cpu() must check for an Error rather than NULL return value. > > While at it, clean up a superfluous NULL check. > > Reported-by: Jan Kiszka <[email protected]> > Cc: [email protected] > Cc: Igor Mammedov <[email protected]> > Signed-off-by: Andreas Färber <[email protected]>
Ping! Jan, does this address your concerns / use cases? -rc2 is on Wednesday. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
