Re: [Qemu-devel] [PATCH 3/5] pci: designware: Update MSI mapping unconditionally

2019-07-01 Thread Peter Maydell
On Tue, 16 Apr 2019 at 02:39, Andrey Smirnov wrote: > > Expression to calculate update_msi_mapping in code handling writes to > DESIGNWARE_PCIE_MSI_INTR0_ENABLE is missing an ! operator and should > be: > > !!root->msi.intr[0].enable ^ !!val; > > so that MSI mapping is updated when enabled tra

Re: [Qemu-devel] [PATCH 3/5] pci: designware: Update MSI mapping unconditionally

2019-06-17 Thread Michael S. Tsirkin
On Mon, Apr 15, 2019 at 06:39:00PM -0700, Andrey Smirnov wrote: > Expression to calculate update_msi_mapping in code handling writes to > DESIGNWARE_PCIE_MSI_INTR0_ENABLE is missing an ! operator and should > be: > > !!root->msi.intr[0].enable ^ !!val; > > so that MSI mapping is updated when

[Qemu-devel] [PATCH 3/5] pci: designware: Update MSI mapping unconditionally

2019-04-15 Thread Andrey Smirnov
Expression to calculate update_msi_mapping in code handling writes to DESIGNWARE_PCIE_MSI_INTR0_ENABLE is missing an ! operator and should be: !!root->msi.intr[0].enable ^ !!val; so that MSI mapping is updated when enabled transitions from either "none" -> "any" or "any" -> "none". Since that