On Tue, 16 Apr 2019 at 02:39, Andrey Smirnov <[email protected]> wrote: > > Expression to calculate update_msi_mapping in code handling writes to > DESIGNWARE_PCIE_MSI_INTR0_ENABLE is missing an ! operator and should > be: > > !!root->msi.intr[0].enable ^ !!val; > > so that MSI mapping is updated when enabled transitions from either > "none" -> "any" or "any" -> "none". Since that register shouldn't be > written to very often, change the code to update MSI mapping > unconditionally instead of trying to fix the update_msi_mapping logic. > > Signed-off-by: Andrey Smirnov <[email protected]> > Cc: Peter Maydell <[email protected]> > Cc: Michael S. Tsirkin <[email protected]> > Cc: [email protected] > Cc: [email protected] > ---
Reviewed-by: Peter Maydell <[email protected]> thanks -- PMM
