Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support

2012-12-12 Thread Stefan Hajnoczi
On Wed, Dec 12, 2012 at 11:04:16AM +0100, Tim Hardeck wrote: > On 12/11/2012 11:04 AM, Stefan Hajnoczi wrote: > > On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote: > > > > Thanks for addressing my review comments. > > > >> @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque) > >>

Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support

2012-12-12 Thread Tim Hardeck
On 12/11/2012 11:04 AM, Stefan Hajnoczi wrote: > On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote: > > Thanks for addressing my review comments. > >> @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque) >> >> void vnc_write(VncState *vs, const void *data, size_t len) >> { >>

Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support

2012-12-11 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote: Thanks for addressing my review comments. > @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque) > > void vnc_write(VncState *vs, const void *data, size_t len) > { > -buffer_reserve(&vs->output, len); > +buffer_res

[Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support

2012-12-07 Thread Tim Hardeck
This patch adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option "websocket"is