On 12/11/2012 11:04 AM, Stefan Hajnoczi wrote:
> On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote:
>
> Thanks for addressing my review comments.
>
>> @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque)
>>
>> void vnc_write(VncState *vs, const void *data, size_t len)
>> {
>> - buffer_reserve(&vs->output, len);
>> + buffer_reserve(&vs->output, len);
>>
>> - if (vs->csock != -1 && buffer_empty(&vs->output)) {
>> - qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read,
>> vnc_client_write, vs);
>> - }
>> + if (vs->csock != -1 && buffer_empty(&vs->output)) {
>> + qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read,
>> + vnc_client_write, vs);
>> + }
>>
>> - buffer_append(&vs->output, data, len);
>> + buffer_append(&vs->output, data, len);
>
> QEMU uses 4 spaces for indentation.
I don't know how I missed that, probably during the removal of the
previous parts, but `scripts/checkpatch.pl` didn't complain either.Is the rest of the patchset fine? Regards Tim -- SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstr. 5, 90409 Nürnberg, Germany T: +49 (0) 911 74053-0 F: +49 (0) 911 74053-483 http://www.suse.de/
signature.asc
Description: OpenPGP digital signature
