Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug

2012-08-09 Thread liu ping fan
On Thu, Aug 9, 2012 at 3:40 PM, Paolo Bonzini wrote: > Il 09/08/2012 09:28, liu ping fan ha scritto: >> +static void >> +pci_e1000_unmap(PCIDevice *p) >> +{ >> +/* DO NOT FREE anything!until refcnt=0 */ >> +/* isolate from memory view */ >> +} >>> > >>> > At l

Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 09:28, liu ping fan ha scritto: >>> >> +static void >>> >> +pci_e1000_unmap(PCIDevice *p) >>> >> +{ >>> >> +/* DO NOT FREE anything!until refcnt=0 */ >>> >> +/* isolate from memory view */ >>> >> +} >> > >> > At least you need to call the superclass method. >> > > Refer to 00

Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug

2012-08-09 Thread liu ping fan
On Wed, Aug 8, 2012 at 5:56 PM, Paolo Bonzini wrote: > Il 08/08/2012 08:25, Liu Ping Fan ha scritto: >> >> +static void >> +pci_e1000_unmap(PCIDevice *p) >> +{ >> +/* DO NOT FREE anything!until refcnt=0 */ >> +/* isolate from memory view */ >> +} > > At least you need to call the superclas

Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug

2012-08-08 Thread Paolo Bonzini
Il 08/08/2012 08:25, Liu Ping Fan ha scritto: > > +static void > +pci_e1000_unmap(PCIDevice *p) > +{ > +/* DO NOT FREE anything!until refcnt=0 */ > +/* isolate from memory view */ > +} At least you need to call the superclass method. Paolo > static int > pci_e1000_uninit(PCIDevice *d

[Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug

2012-08-07 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- hw/e1000.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 4573f13..fa71455 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -1192,6 +1192,13 @@ e1000_cleanup(VLANClientState *nc) s-