Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug

[Paolo Bonzini]

Il 08/08/2012 08:25, Liu Ping Fan ha scritto:
>  
> +static void
> +pci_e1000_unmap(PCIDevice *p)
> +{
> +    /* DO NOT FREE anything!until refcnt=0 */
> +    /* isolate from memory view */
> +}

At least you need to call the superclass method.

Paolo

>  static int
>  pci_e1000_uninit(PCIDevice *dev)
>  {
> @@ -1275,6 +1282,7 @@ static void e1000_class_init(ObjectClass *klass, void 
> *data)
>      PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
>  
>      k->init = pci_e1000_init;
> +    k->unmap = pci_e1000_unmap;
>      k->exit = pci_e1000_uninit;
>      k->romfile = "pxe-e1000.rom";
>      k->vendor_id = PCI_VENDOR_ID_INTEL;