Re: [Qemu-devel] [PATCH 11/14] linux-user: fpu_save_addr is not used

2011-06-02 Thread Juan Quintela
Peter Maydell wrote: > On 2 June 2011 12:53, Juan Quintela wrote: >> It is only read to set the error code? > >>         err |= __get_user(fpu_save_addr, &sf->fpu_save); >> - >> +        (void)fpu_save_addr; > > In linux-user __get_user can never generate an error: faults > are always caught by t

Re: [Qemu-devel] [PATCH 11/14] linux-user: fpu_save_addr is not used

2011-06-02 Thread Peter Maydell
On 2 June 2011 12:53, Juan Quintela wrote: > It is only read to set the error code? >         err |= __get_user(fpu_save_addr, &sf->fpu_save); > - > +        (void)fpu_save_addr; In linux-user __get_user can never generate an error: faults are always caught by the lock_user_struct() or equivalen

[Qemu-devel] [PATCH 11/14] linux-user: fpu_save_addr is not used

2011-06-02 Thread Juan Quintela
It is only read to set the error code? Signed-off-by: Juan Quintela --- linux-user/signal.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index c7a375f..edf4cdb 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -2