On 2 June 2011 12:53, Juan Quintela <quint...@redhat.com> wrote: > It is only read to set the error code?
> err |= __get_user(fpu_save_addr, &sf->fpu_save); > - > + (void)fpu_save_addr; In linux-user __get_user can never generate an error: faults are always caught by the lock_user_struct() or equivalent call done beforehand. The error handling is I think a leftover from code borrowed from the kernel (which does have a __get_user that might return an error). So I think the correct fix here is just to remove the __get_user lines and the variables if they're not used. -- PMM
