Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-23 Thread Fabio Fantoni
Il 23/05/2014 16:30, Stefano Stabellini ha scritto: On Fri, 23 May 2014, Fabio Fantoni wrote: One issue is that -M pc didn't always work with Xen. Now it does and we are already relying on it in libxl since 2bc047635b51abd41c917aa2b813211ee0de2c38. It is safe because all QEMU releases from 1.6 o

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-23 Thread Stefano Stabellini
On Fri, 23 May 2014, Fabio Fantoni wrote: > > One issue is that -M pc didn't always work with Xen. Now it does and we > > are already relying on it in libxl since > > 2bc047635b51abd41c917aa2b813211ee0de2c38. It is safe because all QEMU > > releases from 1.6 onward work well with Xen and -M pc. Old

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-23 Thread Fabio Fantoni
One issue is that -M pc didn't always work with Xen. Now it does and we are already relying on it in libxl since 2bc047635b51abd41c917aa2b813211ee0de2c38. It is safe because all QEMU releases from 1.6 onward work well with Xen and -M pc. Older QEMU releases are considered ancient and unmaintained.

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-23 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 23 May 2014 12:37 > To: Paul Durrant > Cc: Stefano Stabellini; Gerd Hoffmann; Paolo Bonzini; qemu- > de...@nongnu.org; Anthony Liguori; m...@redhat.com; Anthony Perard > Subject: RE: [PATCH] xe

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-23 Thread Stefano Stabellini
On Fri, 23 May 2014, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 23 May 2014 11:11 > > To: Paul Durrant > > Cc: Stefano Stabellini; Gerd Hoffmann; Paolo Bonzini; qemu- > > de...@nongnu.org; Anthony Liguori; m...

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-23 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 23 May 2014 11:11 > To: Paul Durrant > Cc: Stefano Stabellini; Gerd Hoffmann; Paolo Bonzini; qemu- > de...@nongnu.org; Anthony Liguori; m...@redhat.com > Subject: RE: [PATCH] xen: make xen-plat

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-23 Thread Stefano Stabellini
On Fri, 23 May 2014, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 22 May 2014 14:57 > > To: Gerd Hoffmann > > Cc: Paolo Bonzini; Stefano Stabellini; Paul Durrant; qemu-devel@nongnu.org; > > Anthony Liguori; m...@

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-23 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 22 May 2014 14:57 > To: Gerd Hoffmann > Cc: Paolo Bonzini; Stefano Stabellini; Paul Durrant; qemu-devel@nongnu.org; > Anthony Liguori; m...@redhat.com > Subject: Re: [PATCH] xen: make xen-platf

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 15:55, Stefano Stabellini ha scritto: > In fact this code only runs for "-M xenfv". If you use "-M pc", the > xen-platform device has to be added manually. Perhaps it would be worthwhile > to do the opposite, i.e. add the xen-platform device to "-M pc" if not using > -nodefaults.

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 02:53:19PM +0200, Gerd Hoffmann wrote: > On Do, 2014-05-22 at 15:35 +0300, Michael S. Tsirkin wrote: > > On Thu, May 22, 2014 at 01:11:28PM +0100, Stefano Stabellini wrote: > > > On Thu, 22 May 2014, Gerd Hoffmann wrote: > > > > Patch hooks up the xen platform device to the

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Stefano Stabellini
On Thu, 22 May 2014, Gerd Hoffmann wrote: > > > Given that libxl always passes -nodefaults to QEMU, this patch is going > > > to effectively disable xen_platform_pci for all Xen users. It is not a > > > good idea. With the patch applied a Xen user would have no way to enable > > > xen_platform_pci

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Stefano Stabellini
On Thu, 22 May 2014, Paolo Bonzini wrote: > Il 22/05/2014 14:11, Stefano Stabellini ha scritto: > > On Thu, 22 May 2014, Gerd Hoffmann wrote: > > > Patch hooks up the xen platform device to the default device code we > > > have in qemu. Two effects: > > > > > > (1) The device will not be create

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Stefano Stabellini
On Thu, 22 May 2014, Gerd Hoffmann wrote: > Hi, > > > Given that libxl always passes -nodefaults to QEMU, this patch is going > > to effectively disable xen_platform_pci for all Xen users. It is not a > > good idea. With the patch applied a Xen user would have no way to enable > > xen_platform_p

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Gerd Hoffmann
> > Given that libxl always passes -nodefaults to QEMU, this patch is going > > to effectively disable xen_platform_pci for all Xen users. It is not a > > good idea. With the patch applied a Xen user would have no way to enable > > xen_platform_pci except for passing some magic command line runes

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Gerd Hoffmann
On Do, 2014-05-22 at 15:35 +0300, Michael S. Tsirkin wrote: > On Thu, May 22, 2014 at 01:11:28PM +0100, Stefano Stabellini wrote: > > On Thu, 22 May 2014, Gerd Hoffmann wrote: > > > Patch hooks up the xen platform device to the default device code we > > > have in qemu. Two effects: > > > > > >

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 14:11, Stefano Stabellini ha scritto: On Thu, 22 May 2014, Gerd Hoffmann wrote: Patch hooks up the xen platform device to the default device code we have in qemu. Two effects: (1) The device will not be created in case -nodefaults is specified on the command line. (2) A

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Gerd Hoffmann
Hi, > Given that libxl always passes -nodefaults to QEMU, this patch is going > to effectively disable xen_platform_pci for all Xen users. It is not a > good idea. With the patch applied a Xen user would have no way to enable > xen_platform_pci except for passing some magic command line runes vi

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 01:11:28PM +0100, Stefano Stabellini wrote: > On Thu, 22 May 2014, Gerd Hoffmann wrote: > > Patch hooks up the xen platform device to the default device code we > > have in qemu. Two effects: > > > > (1) The device will not be created in case -nodefaults is specified > >

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Stefano Stabellini
On Thu, 22 May 2014, Gerd Hoffmann wrote: > Patch hooks up the xen platform device to the default device code we > have in qemu. Two effects: > > (1) The device will not be created in case -nodefaults is specified > on the command line. > (2) Autocreating the device is also turned off i

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Michael S. Tsirkin
Thursday, May 22, 2014 3:22 PM > > To: Gerd Hoffmann > > Cc: qemu-devel@nongnu.org; Anthony Liguori > > Subject: Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device > > > > On Thu, May 22, 2014 at 09:20:50AM +0200, Gerd Hoffmann wrote: > > >

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Chen, Tiejun
.org; Anthony Liguori > Subject: Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device > > On Thu, May 22, 2014 at 09:20:50AM +0200, Gerd Hoffmann wrote: > > Patch hooks up the xen platform device to the default device code we > > have in qemu. Two effects: > >

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 09:20:50AM +0200, Gerd Hoffmann wrote: > Patch hooks up the xen platform device to the default device code we > have in qemu. Two effects: > > (1) The device will not be created in case -nodefaults is specified > on the command line. > (2) Autocreating the device

[Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Gerd Hoffmann
Patch hooks up the xen platform device to the default device code we have in qemu. Two effects: (1) The device will not be created in case -nodefaults is specified on the command line. (2) Autocreating the device is also turned off in case xen-platform is added manually via -devic