Hi,

> Given that libxl always passes -nodefaults to QEMU, this patch is going
> to effectively disable xen_platform_pci for all Xen users. It is not a
> good idea. With the patch applied a Xen user would have no way to enable
> xen_platform_pci except for passing some magic command line runes via
> device_model_args_hvm.

Indeed.

> > @@ -4101,6 +4103,7 @@ int main(int argc, char **argv, char **envp)
> >          default_monitor = 0;
> >          default_net = 0;
> >          default_vga = 0;
> > +        default_xenplatform = 0;
> >      }

With that chunk removed -nodefaults will have no effect for the xen
platform device, but explicitly moving it somewhere else via -device
xen-platform,addr=$slot should still work.

cheers,
  Gerd



Reply via email to