Re: [Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related function

2012-12-03 Thread li guang
在 2012-12-03一的 10:43 +0100,Jan Kiszka写道: > On 2012-12-03 04:07, liguang wrote: > > 1. define names of breakpoints in dr7 > > 2. slightly refactor bits field of breakpoint > >related functions. > > Two topics, (at least) two patches, please. The code is hairy - not your > fault, you actually tr

Re: [Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related function

2012-12-03 Thread li guang
在 2012-12-03一的 12:19 +0100,Andreas Färber写道: > Am 03.12.2012 10:43, schrieb Jan Kiszka: > > On 2012-12-03 04:07, liguang wrote: > >> 1. define names of breakpoints in dr7 > >> 2. slightly refactor bits field of breakpoint > >>related functions. > > > > Two topics, (at least) two patches, pleas

Re: [Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related function

2012-12-03 Thread Andreas Färber
Am 03.12.2012 10:43, schrieb Jan Kiszka: > On 2012-12-03 04:07, liguang wrote: >> 1. define names of breakpoints in dr7 >> 2. slightly refactor bits field of breakpoint >>related functions. > > Two topics, (at least) two patches, please. The code is hairy - not your > fault, you actually try t

Re: [Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related function

2012-12-03 Thread Jan Kiszka
On 2012-12-03 04:07, liguang wrote: > 1. define names of breakpoints in dr7 > 2. slightly refactor bits field of breakpoint >related functions. Two topics, (at least) two patches, please. The code is hairy - not your fault, you actually try to improve it. But splitting up makes review easier.

[Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related function

2012-12-02 Thread liguang
1. define names of breakpoints in dr7 2. slightly refactor bits field of breakpoint related functions. Signed-off-by: liguang --- target-i386/cpu.h |6 target-i386/helper.c | 59 target-i386/machine.c |2 +- target-i