Am 03.12.2012 10:43, schrieb Jan Kiszka: > On 2012-12-03 04:07, liguang wrote: >> 1. define names of breakpoints in dr7 >> 2. slightly refactor bits field of breakpoint >> related functions. > > Two topics, (at least) two patches, please. The code is hairy - not your > fault, you actually try to improve it. But splitting up makes review > easier. Thanks in advance.
I was going to request the same thing: Please first introduce the new constants, then do functional changes on top. When you do that, please remember to include a short cover letter and use git-send-email so that the patches stay together. :) The following link may be helpful for avoiding coding style issues: http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
