Re: [Qemu-devel] [PATCH] qemu: add .exrc

2012-07-20 Thread Michael S. Tsirkin
On Fri, Jul 20, 2012 at 11:34:21AM +0100, Peter Maydell wrote: > On 20 July 2012 11:26, Stefan Hajnoczi wrote: > > From my .vimrc: > > > > au BufNewFile,BufRead */qemu/*.c,*/qemu/*.h,*/qemu/*.hx,*/qemu/*tool > > setlocal ts=4 sw=4 et > > Basically I think editor preferences are a local matter whi

Re: [Qemu-devel] [PATCH] qemu: add .exrc

2012-07-20 Thread Wei-Ren Chen
> In any case, 3 settings clearly don't encompass the whole of > QEMU's coding style. The relevant bit of my .emacs tweaks about > 20 different settings... Just leave the coding style checking to checkpatch.pl, I think? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of

Re: [Qemu-devel] [PATCH] qemu: add .exrc

2012-07-20 Thread Peter Maydell
On 20 July 2012 11:26, Stefan Hajnoczi wrote: > From my .vimrc: > > au BufNewFile,BufRead */qemu/*.c,*/qemu/*.h,*/qemu/*.hx,*/qemu/*tool > setlocal ts=4 sw=4 et Basically I think editor preferences are a local matter which can reasonably differ between different developers, so they shouldn't be i

Re: [Qemu-devel] [PATCH] qemu: add .exrc

2012-07-20 Thread Stefan Hajnoczi
On Thu, Jul 19, 2012 at 4:24 PM, Michael S. Tsirkin wrote: > On Thu, Jul 19, 2012 at 04:11:21PM +0100, Peter Maydell wrote: >> On 19 July 2012 15:29, Michael S. Tsirkin wrote: >> > I've been using this to get correct indenting with vim >> > in qemu for a while, but it's a bit easier if we >> > pu

Re: [Qemu-devel] [PATCH] qemu: add .exrc

2012-07-19 Thread Michael S. Tsirkin
On Thu, Jul 19, 2012 at 04:11:21PM +0100, Peter Maydell wrote: > On 19 July 2012 15:29, Michael S. Tsirkin wrote: > > I've been using this to get correct indenting with vim > > in qemu for a while, but it's a bit easier if we > > put the settings in the central place. > > Note that > > 1. you stil

Re: [Qemu-devel] [PATCH] qemu: add .exrc

2012-07-19 Thread Peter Maydell
On 19 July 2012 15:29, Michael S. Tsirkin wrote: > I've been using this to get correct indenting with vim > in qemu for a while, but it's a bit easier if we > put the settings in the central place. > Note that > 1. you still need to enable 'exrc' and 'secure' >options in your vimrc for these s

[Qemu-devel] [PATCH] qemu: add .exrc

2012-07-19 Thread Michael S. Tsirkin
I've been using this to get correct indenting with vim in qemu for a while, but it's a bit easier if we put the settings in the central place. Note that 1. you still need to enable 'exrc' and 'secure' options in your vimrc for these settings to take effect. 2. you can create a .vimrc file if 'ex