On Fri, Jul 20, 2012 at 11:34:21AM +0100, Peter Maydell wrote: > On 20 July 2012 11:26, Stefan Hajnoczi <stefa...@gmail.com> wrote: > > From my .vimrc: > > > > au BufNewFile,BufRead */qemu/*.c,*/qemu/*.h,*/qemu/*.hx,*/qemu/*tool > > setlocal ts=4 sw=4 et > > Basically I think editor preferences are a local matter which > can reasonably differ between different developers, so they > shouldn't be in the git repo.
This is why I simply set the shiftwidth and set indenting by space. Clearly no "can reasonably differ" applies here. > (a) haven't you just demonstrated that even vim users have > different preferred settings? No, it's the same with the addition of tabstop=4, which *is* a matter of taste (how many spaces you want shown if you edit a file with tabs, like a makefile). > (b) where do we stop? emacs? bbedit? there are a lot of editors > out there... If people ask for it we can consider. I doubt it will be a real problem. > In any case, 3 settings clearly don't encompass the whole of > QEMU's coding style. > The relevant bit of my .emacs tweaks about > 20 different settings... > > -- PMM If you don't use vim why do you even care about this patch? -- MST
