Re: [Qemu-devel] [PATCH] i386: Remove REGPARM

2012-02-15 Thread Blue Swirl
On Wed, Feb 15, 2012 at 19:36, Richard Henderson wrote: > On 02/15/2012 10:11 AM, Blue Swirl wrote: >>  #if defined(CONFIG_SOFTMMU) >> -    int mem_index, s_bits, arg_idx; >> +    int mem_index, s_bits; >> +#if TCG_TARGET_REG_BITS == 64 >> +    int arg_idx; >> +#else >> +    int stack_adjust; >> +

Re: [Qemu-devel] [PATCH] i386: Remove REGPARM

2012-02-15 Thread Richard Henderson
On 02/15/2012 10:11 AM, Blue Swirl wrote: > #if defined(CONFIG_SOFTMMU) > -int mem_index, s_bits, arg_idx; > +int mem_index, s_bits; > +#if TCG_TARGET_REG_BITS == 64 > +int arg_idx; > +#else > +int stack_adjust; > +#endif ... > -if (TCG_TARGET_REG_BITS == 64) { > -tcg

[Qemu-devel] [PATCH] i386: Remove REGPARM

2012-02-15 Thread Blue Swirl
Use stack based calling convention (GCC default) for interfacing with generated code instead of register based convention (regparm(3)). Signed-off-by: Blue Swirl --- Performance test results would be appreciated. Quickly tried on i386 and x86_64 hosts with 32 and 64 bit guests. --- osdep.h