Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-23 Thread Peter Maydell
On 23 July 2012 18:45, Peter Maydell wrote: > On 23 July 2012 18:40, Blue Swirl wrote: >> On Tue, Jul 17, 2012 at 7:28 PM, Peter Maydell >> wrote: >>> The trouble is that the warnings and errors here don't cause the >>> build to fail noisily; that's a big distinction IMHO. >>> I suppose we coul

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-23 Thread Peter Maydell
On 23 July 2012 18:40, Blue Swirl wrote: > On Tue, Jul 17, 2012 at 7:28 PM, Peter Maydell > wrote: >> The trouble is that the warnings and errors here don't cause the >> build to fail noisily; that's a big distinction IMHO. >> I suppose we could make compile_prog do something like: >> * run the

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-23 Thread Blue Swirl
On Tue, Jul 17, 2012 at 7:28 PM, Peter Maydell wrote: > On 17 July 2012 20:24, Stefan Weil wrote: >> The arguments why -Werror is a bad idea for some configure tests >> are reasonable. >> >> Nevertheless the QEMU community was able to produce thousands of >> lines of code which compile without a

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Stefan Weil
Am 17.07.2012 21:28, schrieb Peter Maydell: On 17 July 2012 20:24, Stefan Weil wrote: The arguments why -Werror is a bad idea for some configure tests are reasonable. Nevertheless the QEMU community was able to produce thousands of lines of code which compile without a warning, so we should be

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Peter Maydell
On 17 July 2012 20:24, Stefan Weil wrote: > The arguments why -Werror is a bad idea for some configure tests > are reasonable. > > Nevertheless the QEMU community was able to produce thousands of > lines of code which compile without a warning, so we should be able > to create warning and error fr

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Stefan Weil
Am 17.07.2012 20:46, schrieb Peter Maydell: On 17 July 2012 19:32, Stefan Weil wrote: Hello Anthony, hello Blue, these patches fix broken builds, therefore I expected that they would be applied fast: http://patchwork.ozlabs.org/patch/171066/ http://patchwork.ozlabs.org/patch/171067/ http://pa

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Peter Maydell
On 17 July 2012 19:32, Stefan Weil wrote: > Hello Anthony, hello Blue, > > these patches fix broken builds, therefore I expected that they > would be applied fast: > > http://patchwork.ozlabs.org/patch/171066/ > http://patchwork.ozlabs.org/patch/171067/ > http://patchwork.ozlabs.org/patch/171081/

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Stefan Weil
Am 17.07.2012 20:03, schrieb Igor Mitsyanko: I see now that this bug was already noticed, please ignore this mail On 07/17/2012 09:34 PM, Igor Mitsyanko wrote: After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are executed with -Werror flag. Current ALSA configure test p

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Igor Mitsyanko
I see now that this bug was already noticed, please ignore this mail On 07/17/2012 09:34 PM, Igor Mitsyanko wrote: After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are executed with -Werror flag. Current ALSA configure test program invokes a warning: warning: ‘handle’

[Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Igor Mitsyanko
After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are executed with -Werror flag. Current ALSA configure test program invokes a warning: warning: ‘handle’ is used uninitialized in this function [-Wuninitialized] which results in error with -Werror flag and, consequently,