Am 17.07.2012 21:28, schrieb Peter Maydell:
On 17 July 2012 20:24, Stefan Weil <[email protected]> wrote:
The arguments why -Werror is a bad idea for some configure tests
are reasonable.
Nevertheless the QEMU community was able to produce thousands of
lines of code which compile without a warning, so we should be able
to create warning and error free code for a handful of configure
tests.
The trouble is that the warnings and errors here don't cause the
build to fail noisily; that's a big distinction IMHO.
I suppose we could make compile_prog do something like:
* run the compile test
* if it fails => test failure as now
* if it succeeds (and we're doing a Werror build at all),
rerun the same test with -Werror
* if that fails, abort configure with an error message
Then we would have the same "make the problem obvious" effect
that plain -Werror provides for our main compilation.
Good idea. Of course it will increase the time needed for
running the default configure, but I think that's acceptable
if we don't use it for the tests of the compiler warning options.
