Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-12 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 12.05.2014 19:05, schrieb Eric Blake: > [adding libvirt] > > On 05/09/2014 05:54 AM, Gerd Hoffmann wrote: >> Hi, >> >>> virt-manager/libvirt seems to default to 9 MByte of Vram for >>> cirrus, so this would break a lot of setups. >> >> It wouldn'

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-12 Thread Eric Blake
[adding libvirt] On 05/09/2014 05:54 AM, Gerd Hoffmann wrote: > Hi, > >> virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus, >> so this would break a lot of setups. > > It wouldn't. libvirt sticks that into the xml, but it doesn't set any > qemu parameters. The libvirt param

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-12 Thread Eric Blake
On 05/09/2014 05:18 AM, Dr. David Alan Gilbert wrote: > * arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: >> From: Gonglei >> >> when configure a invalid vram size for cirrus card, such as less >> 2 MB, which will crash qemu. Follow the real hardware, the cirrus >> card has 4 MB video mem

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 13:18, Dr. David Alan Gilbert ha scritto: * arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: From: Gonglei when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also f

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus, > > so this would break a lot of setups. > > It wouldn't. libvirt sticks that into the xml, but it doesn't set any > qemu parameters. The libvirt parameter actually pred

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Gerd Hoffmann
Hi, > virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus, > so this would break a lot of setups. It wouldn't. libvirt sticks that into the xml, but it doesn't set any qemu parameters. The libvirt parameter actually predates the qemu property for setting the size. > Looking a

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Andreas Färber
Am 09.05.2014 12:59, schrieb Gonglei (Arei): >> -Original Message- >> From: Gerd Hoffmann [mailto:kra...@redhat.com] >> Sent: Friday, May 09, 2014 6:55 PM >> To: Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; afaer...@suse.de; m...@redhat.com; >> pbonz...@redhat.com; Huangweidong (C); Blue Sw

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Dr. David Alan Gilbert
* arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: > From: Gonglei > > when configure a invalid vram size for cirrus card, such as less > 2 MB, which will crash qemu. Follow the real hardware, the cirrus > card has 4 MB video memory. Also for backward compatibility, accept > 8 MB and 16 M

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, May 09, 2014 6:55 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; m...@redhat.com; > pbonz...@redhat.com; Huangweidong (C); Blue Swirl > Subject: Re: [PATCH] cirrus_vga: adding sani

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gerd Hoffmann
Hi, > BTW, what's your opinion about isa cirrus vga device, Gerd? I'd do the same check there. cheers, Gerd

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, May 09, 2014 6:31 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; m...@redhat.com; > pbonz...@redhat.com; Huangweidong (C); Blue Swirl > Subject: Re: [PATCH] cirrus_vga: adding

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gerd Hoffmann
On Fr, 2014-05-09 at 18:21 +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > when configure a invalid vram size for cirrus card, such as less > 2 MB, which will crash qemu. Follow the real hardware, the cirrus > card has 4 MB video memory. Also for backward compatibility, accept > 8 MB an

[Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread arei.gonglei
From: Gonglei when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward compatibility, accept 8 MB and 16 MB vram size. Signed-off-by: Gonglei --- For isa cirrus vga device, it