Hi, > -----Original Message----- > From: Gerd Hoffmann [mailto:[email protected]] > Sent: Friday, May 09, 2014 6:31 PM > To: Gonglei (Arei) > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; Huangweidong (C); Blue Swirl > Subject: Re: [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch > false positive?] > > On Fr, 2014-05-09 at 18:21 +0800, [email protected] wrote: > > From: Gonglei <[email protected]> > > > > when configure a invalid vram size for cirrus card, such as less > > 2 MB, which will crash qemu. Follow the real hardware, the cirrus > > card has 4 MB video memory. Also for backward compatibility, accept > > 8 MB and 16 MB vram size. > > Fails checkpatch: > > === checkpatch complains === > WARNING: suspect code indent for conditional statements (5, 9) > #12: FILE: hw/display/cirrus_vga.c:2964: > + if (s->vga.vram_size_mb != 4 || s->vga.vram_size_mb != 8 || > [...] > + error_report("Invalid cirrus_vga ram size '%u'\n", > s->vga.vram_size_mb); > > WARNING: line over 80 characters > #14: FILE: hw/display/cirrus_vga.c:2966: > + error_report("Invalid cirrus_vga ram size '%u'\n", > s->vga.vram_size_mb); > > total: 0 errors, 2 warnings, 13 lines checked > Sorry for my negligence. I will post another patch.
BTW, what's your opinion about isa cirrus vga device, Gerd? Best regards, -Gonglei
