Re: [Qemu-devel] [PATCH] char-pty: remove unnecessary #ifdef

2018-08-30 Thread Roman Bolshakov
On Wed, Aug 22, 2018 at 12:38:35PM +0200, Paolo Bonzini wrote: > For some reason __APPLE__ was not checked in pty code. However, the #ifdef > is redundant: this file is already compiled only if CONFIG_POSIX, same as > util/qemu-openpty.c which it uses. > Hi Paolo, Is it possible to apply the pa

Re: [Qemu-devel] [PATCH] char-pty: remove unnecessary #ifdef

2018-08-23 Thread Paolo Bonzini
On 23/08/2018 00:12, Roman Bolshakov wrote: > On Wed, Aug 22, 2018 at 12:38:35PM +0200, Paolo Bonzini wrote: >> For some reason __APPLE__ was not checked in pty code. However, the #ifdef >> is redundant: this file is already compiled only if CONFIG_POSIX, same as >> util/qemu-openpty.c which it us

Re: [Qemu-devel] [PATCH] char-pty: remove unnecessary #ifdef

2018-08-22 Thread Roman Bolshakov
On Wed, Aug 22, 2018 at 12:38:35PM +0200, Paolo Bonzini wrote: > For some reason __APPLE__ was not checked in pty code. However, the #ifdef > is redundant: this file is already compiled only if CONFIG_POSIX, same as > util/qemu-openpty.c which it uses. > Thanks Paolo! FWIW, qemu_openpty_raw and

[Qemu-devel] [PATCH] char-pty: remove unnecessary #ifdef

2018-08-22 Thread Paolo Bonzini
For some reason __APPLE__ was not checked in pty code. However, the #ifdef is redundant: this file is already compiled only if CONFIG_POSIX, same as util/qemu-openpty.c which it uses. Reported-by: Roman Bolshakov Signed-off-by: Paolo Bonzini --- chardev/char-pty.c | 6 -- 1 file changed, 6