On 23/08/2018 00:12, Roman Bolshakov wrote: > On Wed, Aug 22, 2018 at 12:38:35PM +0200, Paolo Bonzini wrote: >> For some reason __APPLE__ was not checked in pty code. However, the #ifdef >> is redundant: this file is already compiled only if CONFIG_POSIX, same as >> util/qemu-openpty.c which it uses. >> > > Thanks Paolo! > > FWIW, qemu_openpty_raw and qemu_pipe are declared for all operating > systems except _WIN32 in qemu-common.h. For sake of symmetry, should the > declarations be available only for CONFIG_POSIX?
I would even move them out of qemu-common.h to a separate qemu/openpty.h file... Paolo
