Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 10:08, Markus Armbruster wrote: > > Remember, Markus' patch was about removing asynchronous commands, > > because _those_ commands were where "id" was mishandled (and if we DID > > want asynch commands, it would be even MORE important that they handle > > id corerctly). But he acci

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Wen Congyang
On 06/08/2015 04:17 PM, Paolo Bonzini wrote: > > > On 08/06/2015 10:10, Markus Armbruster wrote: +} else if (!strcmp(arg_name, "id")) { +/* Ignored, necessary for backwards compatibility */ } else { error_set(errp, QERR_QMP_EXTRA_MEMBE

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Paolo Bonzini
On 08/06/2015 10:10, Markus Armbruster wrote: > > > +} else if (!strcmp(arg_name, "id")) { > > > +/* Ignored, necessary for backwards compatibility */ > > > } else { > > > error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name); > > > return NULL; >

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/06/2015 16:17, Pavel Fedin wrote: >> This fixes QMP regression: >> http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html >> >> Signed-off-by: Pavel Fedin >> --- >> monitor.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/monitor.c b/mo

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-08 Thread Markus Armbruster
Eric Blake writes: > On 06/05/2015 08:32 AM, Daniel P. Berrange wrote: >> On Fri, Jun 05, 2015 at 05:17:29PM +0300, Pavel Fedin wrote: >>> This fixes QMP regression: >>> http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html >>> >>> Signed-off-by: Pavel Fedin >>> --- >>> monitor.c |

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-05 Thread Eric Blake
On 06/05/2015 08:32 AM, Daniel P. Berrange wrote: > On Fri, Jun 05, 2015 at 05:17:29PM +0300, Pavel Fedin wrote: >> This fixes QMP regression: >> http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html >> >> Signed-off-by: Pavel Fedin >> --- >> monitor.c | 2 ++ >> 1 file changed, 2 in

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-05 Thread Eric Blake
On 06/05/2015 08:17 AM, Pavel Fedin wrote: > This fixes QMP regression: > http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html > > Signed-off-by: Pavel Fedin > --- > monitor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/monitor.c b/monitor.c > index c7baa91..ef21bba

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-05 Thread Paolo Bonzini
On 05/06/2015 16:17, Pavel Fedin wrote: > This fixes QMP regression: > http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html > > Signed-off-by: Pavel Fedin > --- > monitor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/monitor.c b/monitor.c > index c7baa91..ef21bba

Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-05 Thread Daniel P. Berrange
On Fri, Jun 05, 2015 at 05:17:29PM +0300, Pavel Fedin wrote: > This fixes QMP regression: > http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html > > Signed-off-by: Pavel Fedin > --- > monitor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/monitor.c b/monitor.c > inde

[Qemu-devel] [PATCH] Do not fail if id field is present.

2015-06-05 Thread Pavel Fedin
This fixes QMP regression: http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html Signed-off-by: Pavel Fedin --- monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/monitor.c b/monitor.c index c7baa91..ef21bba 100644 --- a/monitor.c +++ b/monitor.c @@ -4955,6 +4955,8 @@ s