Re: [Qemu-devel] [PATCH] Do not fail if id field is present.

[Wen Congyang]

On 06/08/2015 04:17 PM, Paolo Bonzini wrote:
> 
> 
> On 08/06/2015 10:10, Markus Armbruster wrote:
>>>> +        } else if (!strcmp(arg_name, "id")) {
>>>> +            /* Ignored, necessary for backwards compatibility */
>>>>          } else {
>>>>              error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
>>>>              return NULL;
>>>>
>>>
>>> Nope, this is not enough to fix virt-test.
>> Really?  Details?
> 
> It really wants the id in the reply to match the id in the request.

In handle_qmp_command():
    mon->qmp.id = qdict_get(input, "id");
    qobject_incref(mon->qmp.id);
In monitor_protocol_emitter():
    if (mon->qmp.id) {
        qdict_put_obj(qmp, "id", mon->qmp.id);
        mon->qmp.id = NULL;
    }

So I think there is no problems for virt-test.

Thanks
Wen Congyang

> 
> Paolo
> 
>