Re: [PATCH v7 2/4] Add NVMM accelerator: x86 CPU support

2021-04-07 Thread Reinoud Zandijk
On Fri, Apr 02, 2021 at 02:51:41PM -0700, Richard Henderson wrote: > On 4/2/21 1:25 PM, Reinoud Zandijk wrote: > > +i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true: > > + declare_dependency(link_args: ['-lnvmm']) > > +) > > You shouldn't be playing with link flags directly. > > In patch 1, you

Re: [PATCH v7 2/4] Add NVMM accelerator: x86 CPU support

2021-04-02 Thread Richard Henderson
On 4/2/21 1:25 PM, Reinoud Zandijk wrote: +i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true: + declare_dependency(link_args: ['-lnvmm']) +) You shouldn't be playing with link flags directly. In patch 1, you found the nvmm library, and assigned it to the variable 'nvmm'. You should just add

[PATCH v7 2/4] Add NVMM accelerator: x86 CPU support

2021-04-02 Thread Reinoud Zandijk
Signed-off-by: Kamil Rytarowski Signed-off-by: Reinoud Zandijk --- target/i386/meson.build |1 + target/i386/nvmm/meson.build | 10 + target/i386/nvmm/nvmm-accel-ops.c | 111 +++ target/i386/nvmm/nvmm-accel-ops.h | 24 + target/i386/nvmm/nvmm-all.c | 1226 +