On Fri, Apr 02, 2021 at 02:51:41PM -0700, Richard Henderson wrote: > On 4/2/21 1:25 PM, Reinoud Zandijk wrote: > > +i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true: > > + declare_dependency(link_args: ['-lnvmm']) > > +) > > You shouldn't be playing with link flags directly. > > In patch 1, you found the nvmm library, and assigned it to the variable > 'nvmm'. You should just add the library as a dependency and let meson > figure out what to do. > > So I think this should just be > > i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true: nvmm)
Thanks for the patch :) I will incorporate it! Reinoud
