Re: [PATCH v6 5/8] device/virtio-nsm: Support for Nitro Secure Module device

2024-09-15 Thread Michael S. Tsirkin
On Fri, Sep 06, 2024 at 01:57:32AM +0600, Dorjoy Chowdhury wrote: > +const struct nsm_cmd nsm_cmds[] = { > +{ "GetRandom", CBOR_ROOT_TYPE_STRING, handle_GetRandom }, > +{ "DescribeNSM", CBOR_ROOT_TYPE_STRING, handle_DescribeNSM }, > +{ "DescribePCR", CBOR_ROOT_TYPE_MAP, handle_D

Re: [PATCH v6 5/8] device/virtio-nsm: Support for Nitro Secure Module device

2024-09-15 Thread Michael S. Tsirkin
On Mon, Sep 16, 2024 at 01:46:52AM +0600, Dorjoy Chowdhury wrote: > > +    len = cbor_serialize(root, response->iov_base, response->iov_len); > > As far as I can tell, all these also need to be switched to use > iov_from_buf. > > > Sorry I didn't understand this. The iovecs passed in

Re: [PATCH v6 5/8] device/virtio-nsm: Support for Nitro Secure Module device

2024-09-15 Thread Dorjoy Chowdhury
On Mon, Sep 16, 2024, 1:26 AM Michael S. Tsirkin wrote: > On Fri, Sep 06, 2024 at 01:57:32AM +0600, Dorjoy Chowdhury wrote: > > Nitro Secure Module (NSM)[1] device is used in AWS Nitro Enclaves[2] > > for stripped down TPM functionality like cryptographic attestation. > > The requests to and resp

Re: [PATCH v6 5/8] device/virtio-nsm: Support for Nitro Secure Module device

2024-09-15 Thread Michael S. Tsirkin
On Fri, Sep 06, 2024 at 01:57:32AM +0600, Dorjoy Chowdhury wrote: > Nitro Secure Module (NSM)[1] device is used in AWS Nitro Enclaves[2] > for stripped down TPM functionality like cryptographic attestation. > The requests to and responses from NSM device are CBOR[3] encoded. > > This commit adds s

[PATCH v6 5/8] device/virtio-nsm: Support for Nitro Secure Module device

2024-09-05 Thread Dorjoy Chowdhury
Nitro Secure Module (NSM)[1] device is used in AWS Nitro Enclaves[2] for stripped down TPM functionality like cryptographic attestation. The requests to and responses from NSM device are CBOR[3] encoded. This commit adds support for NSM device in QEMU. Although related to AWS Nitro Enclaves, the v