On Fri, Sep 06, 2024 at 01:57:32AM +0600, Dorjoy Chowdhury wrote:
> +const struct nsm_cmd nsm_cmds[] = {
> + { "GetRandom", CBOR_ROOT_TYPE_STRING, handle_GetRandom },
> + { "DescribeNSM", CBOR_ROOT_TYPE_STRING, handle_DescribeNSM },
> + { "DescribePCR", CBOR_ROOT_TYPE_MAP, handle_DescribePCR },
> + { "ExtendPCR", CBOR_ROOT_TYPE_MAP, handle_ExtendPCR },
> + { "LockPCR", CBOR_ROOT_TYPE_MAP, handle_LockPCR },
> + { "LockPCRs", CBOR_ROOT_TYPE_MAP, handle_LockPCRs },
> + { "Attestation", CBOR_ROOT_TYPE_MAP, handle_Attestation },
> +};
I think we should stick to the coding style and avoid camel case
for functions. I know, it is tempting to stick to what
some spec says, but they are all inconsistent. Put the spec
name in a code comment before the function, should be
good enough.
