Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()

2019-11-29 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 29.11.2019 9:10, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> No reason for local_err here, use errp directly instead. >> >> Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize". >> I'm surprised it's just two.

Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()

2019-11-29 Thread Vladimir Sementsov-Ogievskiy
29.11.2019 9:10, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> No reason for local_err here, use errp directly instead. > > Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize". > I'm surprised it's just two. Did you search for the anti-pattern > systemat

Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()

2019-11-28 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > No reason for local_err here, use errp directly instead. Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize". I'm surprised it's just two. Did you search for the anti-pattern systematically? > Signed-off-by: Vladimir Sementsov-Ogievskiy

RE: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()

2019-11-27 Thread Gonglei (Arei)
ur...@gmail.com; > phi...@redhat.com; vsement...@virtuozzo.com > Subject: [PATCH v6] backends/cryptodev: drop local_err from > cryptodev_backend_complete() > > No reason for local_err here, use errp directly instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed

[PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete()

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
No reason for local_err here, use errp directly instead. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau --- v6: add r-b by Philippe and Marc-André backends/cryptodev.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletio