Vladimir Sementsov-Ogievskiy <[email protected]> writes: > No reason for local_err here, use errp directly instead.
Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize". I'm surprised it's just two. Did you search for the anti-pattern systematically? > Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > Reviewed-by: Marc-André Lureau <[email protected]> > --- > > v6: add r-b by Philippe and Marc-André > > backends/cryptodev.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/backends/cryptodev.c b/backends/cryptodev.c > index 3c071eab95..5a9735684e 100644 > --- a/backends/cryptodev.c > +++ b/backends/cryptodev.c > @@ -176,19 +176,10 @@ cryptodev_backend_complete(UserCreatable *uc, Error > **errp) > { > CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc); > CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc); > - Error *local_err = NULL; > > if (bc->init) { > - bc->init(backend, &local_err); > - if (local_err) { > - goto out; > - } > + bc->init(backend, errp); > } > - > - return; > - > -out: > - error_propagate(errp, local_err); > } > > void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used) Reviewed-by: Markus Armbruster <[email protected]>
