Re: [PATCH v2 14/18] ui/sdl: add optional logging when _SDL_DEBUG is set

2023-03-10 Thread Sam Lantinga
If you wanted, you could use the SDL hint system, e.g. if (SDL_GetHintBoolean("QEMU_ENABLE_SDL_LOGGING", SDL_FALSE)) { SDL_LogSetAllPriority(SDL_LOG_PRIORITY_VERBOSE); } Then someone can set that environment variable and it would be using the SDL mechanisms rather than intruding on QEMU... or

Re: [PATCH v2 14/18] ui/sdl: add optional logging when _SDL_DEBUG is set

2023-03-09 Thread Marc-André Lureau
Hi (adding Sam Lantinga, SDL maintainer, in CC. I noticed he worked on QEMU SDL backend yesterday! ;) On Thu, Mar 9, 2023 at 8:40 PM Philippe Mathieu-Daudé wrote: > On 7/3/23 12:56, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Apparently, there is no environment varia

Re: [PATCH v2 14/18] ui/sdl: add optional logging when _SDL_DEBUG is set

2023-03-09 Thread Philippe Mathieu-Daudé
On 7/3/23 12:56, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Apparently, there is no environment variable you can set for libsdl to enable logging. Why not use getenv() in QEMU then? (similar to _VNC_DEBUG) Signed-off-by: Marc-André Lureau --- include/ui/sdl2.h | 2 ++ u

[PATCH v2 14/18] ui/sdl: add optional logging when _SDL_DEBUG is set

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Apparently, there is no environment variable you can set for libsdl to enable logging. (similar to _VNC_DEBUG) Signed-off-by: Marc-André Lureau --- include/ui/sdl2.h | 2 ++ ui/sdl2.c | 4 2 files changed, 6 insertions(+) diff --git a/include/ui/sdl2.h b/