Hi (adding Sam Lantinga, SDL maintainer, in CC. I noticed he worked on QEMU SDL backend yesterday! ;)
On Thu, Mar 9, 2023 at 8:40 PM Philippe Mathieu-Daudé <[email protected]> wrote: > On 7/3/23 12:56, [email protected] wrote: > > From: Marc-André Lureau <[email protected]> > > > > Apparently, there is no environment variable you can set for libsdl to > > enable logging. > > Why not use getenv() in QEMU then? > QEMU has few environment variables. We generally prefer qmp/cmd arguments. And that change does not fit with QEMU tracing etc. > > (similar to _VNC_DEBUG) > > > > Signed-off-by: Marc-André Lureau <[email protected]> > > --- > > include/ui/sdl2.h | 2 ++ > > ui/sdl2.c | 4 ++++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h > > index 8fb7e08262..6fea36db82 100644 > > --- a/include/ui/sdl2.h > > +++ b/include/ui/sdl2.h > > @@ -6,6 +6,8 @@ > > > > #include <SDL.h> > > > > +/* #define _SDL_DEBUG 1 */ > > + > > /* with Alpine / muslc SDL headers pull in directfb headers > > * which in turn trigger warning about redundant decls for > > * direct_waitqueue_deinit. > > diff --git a/ui/sdl2.c b/ui/sdl2.c > > index f259e4c4d1..592eca3e1c 100644 > > --- a/ui/sdl2.c > > +++ b/ui/sdl2.c > > @@ -841,6 +841,10 @@ static void sdl2_display_init(DisplayState *ds, > DisplayOptions *o) > > } > > #endif > > > > +#ifdef _SDL_DEBUG > > + SDL_LogSetAllPriority(SDL_LOG_PRIORITY_VERBOSE); > > +#endif > Sam, do you suggest a better way to enable SDL debugging when starting QEMU? Is there a way to enable it with existing SDL environment variables? thanks > + > > if (SDL_Init(SDL_INIT_VIDEO)) { > > fprintf(stderr, "Could not initialize SDL(%s) - exiting\n", > > SDL_GetError()); > >
