RE: [PATCH v2 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path()

2020-08-25 Thread Chenqun (kuhn)
> > > hw/usb/bus.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/hw/usb/bus.c b/hw/usb/bus.c index > > > b17bda3b29..7bab0499ad > > > 100644 > > > --- a/hw/usb/bus.c > > > +++ b/hw/usb/bus.c > > > @@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(Dev

RE: [PATCH v2 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path()

2020-08-25 Thread Chenqun (kuhn)
> > hw/usb/bus.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/usb/bus.c b/hw/usb/bus.c index b17bda3b29..7bab0499ad > > 100644 > > --- a/hw/usb/bus.c > > +++ b/hw/usb/bus.c > > @@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(DeviceState > > *qdev) >

Re: [PATCH v2 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path()

2020-08-25 Thread Markus Armbruster
Chen Qun writes: > Clang static code analyzer show warning: > qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read > pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > Cc: Gerd Hoffmann > Cc: Marku

[PATCH v2 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path()

2020-08-25 Thread Chen Qun
Clang static code analyzer show warning: qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx", Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Gerd Hoffmann Cc: Markus Armbruster --- hw/usb/bus.c | 4