> > > hw/usb/bus.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/hw/usb/bus.c b/hw/usb/bus.c index
> > > b17bda3b29..7bab0499ad
> > > 100644
> > > --- a/hw/usb/bus.c
> > > +++ b/hw/usb/bus.c
> > > @@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(DeviceState
> > > *qdev)
> > if (in[0] == '.') {
> > /* some hub between root port and device */
> > pos += snprintf(fw_path + pos, fw_len - pos,
> > "hub@%lx/", nr);
> > > in++;
> > > } else {
> > > /* the device itself */
> > > - pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx",
> > > - qdev_fw_name(qdev), nr);
> > > + snprintf(fw_path + pos, fw_len - pos, "%s@%lx",
> > qdev_fw_name(qdev),
> > > + nr);
> > > break;
> > > }
> > > }
> >
> > I'd prefer to keep the line break where it is:
> >
> > snprintf(fw_path + pos, fw_len - pos, "%s@%lx",
> > qdev_fw_name(qdev), nr);
> >
> > The patch is safe, so
> > Reviewed-by: Markus Armbruster <[email protected]>
> >
> > The loss of symmetry betwen the two arms of the if is a bit sad. Up to
> > Gerd.
>
> If symmetry looks better. I should change it later.
Oops, I think I just misunderstood you. I agree with your suggestion to the
formatting of the "snprintf(***)" statement.
If the 'pos' assignment is useless, we delete it avoid warning that are always
detected by some tools.
Thanks,
Chen Qun
