Re: [PATCH v1 4/5] linux-user: log page table changes under -d page

2019-12-02 Thread Richard Henderson
On 12/1/19 1:26 AM, Richard Henderson wrote: > On 11/28/19 7:46 PM, Alex Bennée wrote: >> +if (qemu_loglevel_mask(CPU_LOG_PAGE)) { >> +qemu_log_lock(); >> +qemu_log("new page @ 0x"TARGET_ABI_FMT_lx" updates page map:\n", >> start); >> +log_page_dump(); >> +qemu_

Re: [PATCH v1 4/5] linux-user: log page table changes under -d page

2019-12-01 Thread Richard Henderson
On 11/28/19 7:46 PM, Alex Bennée wrote: > +if (qemu_loglevel_mask(CPU_LOG_PAGE)) { > +qemu_log_lock(); > +qemu_log("new page @ 0x"TARGET_ABI_FMT_lx" updates page map:\n", > start); > +log_page_dump(); > +qemu_log_unlock(); > +} Hmm. The language used here

[PATCH v1 4/5] linux-user: log page table changes under -d page

2019-11-28 Thread Alex Bennée
The CPU_LOG_PAGE flag is woefully underused and could stand to do extra duty tracking page changes. If the user doesn't want to see the details as things change they still have the tracepoints available. Signed-off-by: Alex Bennée --- linux-user/mmap.c | 11 +++ 1 file changed, 7 inserti