Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-21 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 04:25:07PM +0100, Peter Maydell wrote: > On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé wrote: > > Test reliability is a different thing. If a particular test is > > flaky, it needs to either be fixed or disabled. Splitting into > > a fast & slow grouping doesn't address

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 04:25:07PM +0100, Peter Maydell wrote: > On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé wrote: > > Test reliability is a different thing. If a particular test is > > flaky, it needs to either be fixed or disabled. Splitting into > > a fast & slow grouping doesn't address

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Peter Maydell
On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé wrote: > Test reliability is a different thing. If a particular test is > flaky, it needs to either be fixed or disabled. Splitting into > a fast & slow grouping doesn't address reliability, just hides > the problem from view. On the subject of 'fl

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Oct 18, 2024 at 10:51:08AM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Ros

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 11:28:53AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Oct 18, 2024 at 10:51:03AM -0300, Fabiano Rosas wrote: > >> Daniel P. Berrangé writes: > >> > >> > That could be a good reason to split the migration-test into > >> > two distinct programs.

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Oct 18, 2024 at 10:51:03AM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Oct 18, 2024 at 10:46:55AM +0100, Peter Maydell wrote: >> >> On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé >> >> wrote: >> >> > >> >> > On Thu, Oct 17,

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 10:51:08AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Rosas wrote: > >> >> Recent changes to h

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 10:51:03AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Oct 18, 2024 at 10:46:55AM +0100, Peter Maydell wrote: > >> On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé > >> wrote: > >> > > >> > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosa

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Rosas wrote: >> >> Recent changes to how we invoke the migration tests have >> >> (intentionally) caused them to no

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Oct 18, 2024 at 10:46:55AM +0100, Peter Maydell wrote: >> On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé wrote: >> > >> > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: >> > > Daniel P. Berrangé writes: >> > > >> > > > On Thu, Oct 17, 2024

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Peter Maydell
On Fri, 18 Oct 2024 at 11:00, Daniel P. Berrangé wrote: > > On Fri, Oct 18, 2024 at 10:46:55AM +0100, Peter Maydell wrote: > > We do not have infinite CI resources, unfortunately. Migration > > is competing with everything else for time on CI. You have to > > find a balance between "what do we run

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Alex Bennée
Daniel P. Berrangé writes: > On Fri, Oct 18, 2024 at 10:46:55AM +0100, Peter Maydell wrote: >> On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé wrote: >> > >> > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: >> > > Daniel P. Berrangé writes: >> > > >> > > > On Thu, Oct 17, 2024

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Daniel P . Berrangé
On Fri, Oct 18, 2024 at 10:46:55AM +0100, Peter Maydell wrote: > On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé wrote: > > > > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: > > > Daniel P. Berrangé writes: > > > > > > > On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Rosas wr

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Peter Maydell
On Fri, 18 Oct 2024 at 10:01, Daniel P. Berrangé wrote: > > On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: > > Daniel P. Berrangé writes: > > > > > On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Rosas wrote: > > >> Recent changes to how we invoke the migration tests have > > >>

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-18 Thread Daniel P . Berrangé
On Thu, Oct 17, 2024 at 01:29:35PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Rosas wrote: > >> Recent changes to how we invoke the migration tests have > >> (intentionally) caused them to not be part of the check-qtest target

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-17 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Rosas wrote: >> Recent changes to how we invoke the migration tests have >> (intentionally) caused them to not be part of the check-qtest target >> anymore. Add the check-migration-quick target so we don't lose >> migr

Re: [PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Rosas wrote: > Recent changes to how we invoke the migration tests have > (intentionally) caused them to not be part of the check-qtest target > anymore. Add the check-migration-quick target so we don't lose > migration code testing in this job. Bu

[PATCH 4/4] ci: Add check-migration-quick to the clang job

2024-10-17 Thread Fabiano Rosas
Recent changes to how we invoke the migration tests have (intentionally) caused them to not be part of the check-qtest target anymore. Add the check-migration-quick target so we don't lose migration code testing in this job. Signed-off-by: Fabiano Rosas --- .gitlab-ci.d/buildtest.yml | 2 +- 1 f