On Thu, Oct 17, 2024 at 11:32:11AM -0300, Fabiano Rosas wrote: > Recent changes to how we invoke the migration tests have > (intentionally) caused them to not be part of the check-qtest target > anymore. Add the check-migration-quick target so we don't lose > migration code testing in this job.
But 'check-migration-quick' is only the subset of migration tests, 'check-migration' is all of the migration tests. So surely this is a massive regressions in covage in CI pipelines. Experience shows us that relying on humans to run tests periodically doesn't work well, and they'll slowly bit rot. Migration maintainers don't have a way to run this as gating test for every pull request that merges, and pull requests coming from non-migration maintainers can still break migration code. Any tests in tree need to be exercised by CI as the minimum bar to prevent bit rot from merges. > > Signed-off-by: Fabiano Rosas <faro...@suse.de> > --- > .gitlab-ci.d/buildtest.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml > index 34d3f4e9ab..37247dc5fa 100644 > --- a/.gitlab-ci.d/buildtest.yml > +++ b/.gitlab-ci.d/buildtest.yml > @@ -442,7 +442,7 @@ clang-system: > CONFIGURE_ARGS: --cc=clang --cxx=clang++ --enable-ubsan > --extra-cflags=-fno-sanitize-recover=undefined > TARGETS: alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu > s390x-softmmu > - MAKE_CHECK_ARGS: check-qtest check-tcg > + MAKE_CHECK_ARGS: check-qtest check-tcg check-migration-quick > > clang-user: > extends: .native_build_job_template > -- > 2.35.3 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
