Re: [PATCH 05/13] target/arm: Add and use FIELD definitions for ID_AA64DFR0_EL1

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/11/20 7:34 PM, Richard Henderson wrote: On 2/11/20 9:37 AM, Peter Maydell wrote: if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) { -assert(extract32(cpu->id_aa64dfr0, 12, 4) == brps); -assert(extract32(cpu->id_aa64dfr0, 20, 4) == wrps); -assert(extract32(cpu->

Re: [PATCH 05/13] target/arm: Add and use FIELD definitions for ID_AA64DFR0_EL1

2020-02-11 Thread Richard Henderson
On 2/11/20 9:37 AM, Peter Maydell wrote: > if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) { > -assert(extract32(cpu->id_aa64dfr0, 12, 4) == brps); > -assert(extract32(cpu->id_aa64dfr0, 20, 4) == wrps); > -assert(extract32(cpu->id_aa64dfr0, 28, 4) == ctx_cmps); > +

[PATCH 05/13] target/arm: Add and use FIELD definitions for ID_AA64DFR0_EL1

2020-02-11 Thread Peter Maydell
Add FIELD() definitions for the ID_AA64DFR0_EL1 and use them where we currently have hard-coded bit values. Signed-off-by: Peter Maydell --- target/arm/cpu.h| 10 ++ target/arm/cpu.c| 2 +- target/arm/helper.c | 6 +++--- 3 files changed, 14 insertions(+), 4 deletions(-) diff