Re: [PATCH 05/13] target/arm: Add and use FIELD definitions for ID_AA64DFR0_EL1

[Richard Henderson]

On 2/11/20 9:37 AM, Peter Maydell wrote:
>      if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) {
> -        assert(extract32(cpu->id_aa64dfr0, 12, 4) == brps);
> -        assert(extract32(cpu->id_aa64dfr0, 20, 4) == wrps);
> -        assert(extract32(cpu->id_aa64dfr0, 28, 4) == ctx_cmps);
> +        assert(FIELD_EX32(cpu->id_aa64dfr0, ID_AA64DFR0, BRPS) == brps);
> +        assert(FIELD_EX32(cpu->id_aa64dfr0, ID_AA64DFR0, WRPS) == wrps);
> +        assert(FIELD_EX32(cpu->id_aa64dfr0, ID_AA64DFR0, CTX_CMPS) == 
> ctx_cmps);

Should really be FIELD_EX64.  Otherwise,

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~