Re: [PATCH 0/6] Add nRF51 DETECT signal with test

2023-07-28 Thread Peter Maydell
On Thu, 27 Jul 2023 at 23:51, Chris Laplante wrote: > > Hi Peter, > > > > 2. I also have some implementations for pieces of CLOCK, namely the > > > HFCLKSTART/HFCLKSTOP events and HFCLKSTARTED event. Should I include that > > > in this patch series, or would you prefer it in a separate series? I

Re: [PATCH 0/6] Add nRF51 DETECT signal with test

2023-07-27 Thread Chris Laplante
Hi Peter, > > 2. I also have some implementations for pieces of CLOCK, namely the > > HFCLKSTART/HFCLKSTOP events and HFCLKSTARTED event. Should I include that > > in this patch series, or would you prefer it in a separate series? It is > > unrelated to DETECT and POWER. > > > If you think th

Re: [PATCH 0/6] Add nRF51 DETECT signal with test

2023-07-25 Thread Chris Laplante
> > 2. I also have some implementations for pieces of CLOCK, namely the > > HFCLKSTART/HFCLKSTOP events and HFCLKSTARTED event. Should I include that > > in this patch series, or would you prefer it in a separate series? It is > > unrelated to DETECT and POWER. > > > If you think they're ready

Re: [PATCH 0/6] Add nRF51 DETECT signal with test

2023-07-25 Thread Peter Maydell
On Tue, 25 Jul 2023 at 04:25, Chris Laplante wrote: > > Hi Peter, > > > Thanks for this patchset and especially for the work > > improving the qtest infrastructure. I've given my > > comments on the different patches, and in some cases > > reviewed-by tags. (Where I've given one of those, you shou

Re: [PATCH 0/6] Add nRF51 DETECT signal with test

2023-07-24 Thread Chris Laplante
Hi Peter, > Thanks for this patchset and especially for the work > improving the qtest infrastructure. I've given my > comments on the different patches, and in some cases > reviewed-by tags. (Where I've given one of those, you should > add it to your commit message for the relevant patch under >

Re: [PATCH 0/6] Add nRF51 DETECT signal with test

2023-07-24 Thread Peter Maydell
On Sat, 15 Jul 2023 at 00:27, Chris Laplante wrote: > > This patch series implements the nRF51 DETECT signal > in the GPIO peripheral. A qtest is added exercising the signal. > > To implement the test, named out-GPIO IRQ interception had to be added > to the qtest framework. I also took the opport

[PATCH 0/6] Add nRF51 DETECT signal with test

2023-07-14 Thread Chris Laplante
This patch series implements the nRF51 DETECT signal in the GPIO peripheral. A qtest is added exercising the signal. To implement the test, named out-GPIO IRQ interception had to be added to the qtest framework. I also took the opportunity to improve IRQ interception a bit by adding 'FAIL' respons