On Sat, 15 Jul 2023 at 00:27, Chris Laplante <ch...@laplante.io> wrote: > > This patch series implements the nRF51 DETECT signal > in the GPIO peripheral. A qtest is added exercising the signal. > > To implement the test, named out-GPIO IRQ interception had to be added > to the qtest framework. I also took the opportunity to improve IRQ > interception a bit by adding 'FAIL' responses when interception fails. > Otherwise, it is frustrating to troubleshoot why calls to > qtest_irq_intercept_out and friends appears to do nothing.
Thanks for this patchset and especially for the work improving the qtest infrastructure. I've given my comments on the different patches, and in some cases reviewed-by tags. (Where I've given one of those, you should add it to your commit message for the relevant patch under your Signed-off-by: line, so that when you send the version 2 of the patchset we know that those parts are already reviewed and don't need re-examining. If I said "make some change; otherwise Reviewed-by" that means "make that minor change, and then you can add the tag, etc".) Do you have the parts of this feature that use the DETECT signal in the POWER device, or have you not written those yet ? If you have them, you could send those too in v2. -- PMM
