Re: [PATCH] test: make cached assets for functional tests read-only

2024-10-25 Thread Daniel P . Berrangé
On Fri, Oct 25, 2024 at 09:47:07AM +0200, Thomas Huth wrote: > On 21/10/2024 17.02, Thomas Huth wrote: > > On 21/10/2024 14.36, Daniel P. Berrangé wrote: > > > This ensures that if a functional test runs QEMU with a writable > > > disk pointing to a cached asset, an error will be reported, rather >

Re: [PATCH] test: make cached assets for functional tests read-only

2024-10-25 Thread Thomas Huth
On 21/10/2024 17.02, Thomas Huth wrote: On 21/10/2024 14.36, Daniel P. Berrangé wrote: This ensures that if a functional test runs QEMU with a writable disk pointing to a cached asset, an error will be reported, rather than silently modifying the cache file. As an example, tweaking test_sbsaref

Re: [PATCH] test: make cached assets for functional tests read-only

2024-10-21 Thread Philippe Mathieu-Daudé
On 21/10/24 09:36, Daniel P. Berrangé wrote: This ensures that if a functional test runs QEMU with a writable disk pointing to a cached asset, an error will be reported, rather than silently modifying the cache file. As an example, tweaking test_sbsaref.py to set snapshot=off, results in a clear

Re: [PATCH] test: make cached assets for functional tests read-only

2024-10-21 Thread Thomas Huth
On 21/10/2024 14.36, Daniel P. Berrangé wrote: This ensures that if a functional test runs QEMU with a writable disk pointing to a cached asset, an error will be reported, rather than silently modifying the cache file. As an example, tweaking test_sbsaref.py to set snapshot=off, results in a cle

[PATCH] test: make cached assets for functional tests read-only

2024-10-21 Thread Daniel P . Berrangé
This ensures that if a functional test runs QEMU with a writable disk pointing to a cached asset, an error will be reported, rather than silently modifying the cache file. As an example, tweaking test_sbsaref.py to set snapshot=off, results in a clear error: Command: ./build/qemu-system-aarch64