On Fri, Oct 25, 2024 at 09:47:07AM +0200, Thomas Huth wrote: > On 21/10/2024 17.02, Thomas Huth wrote: > > On 21/10/2024 14.36, Daniel P. Berrangé wrote: > > > This ensures that if a functional test runs QEMU with a writable > > > disk pointing to a cached asset, an error will be reported, rather > > > than silently modifying the cache file. > > > > > > As an example, tweaking test_sbsaref.py to set snapshot=off, > > > results in a clear error: > > > > > > Command: ./build/qemu-system-aarch64 ...snip... -drive > > > file=/var/home/ berrange/.cache/qemu/ > > > download/44cdbae275ef1bb6dab1d5fbb59473d4f741e1c8ea8a80fd9e906b531d6ad461,format=raw,snapshot=off > > > -cpu max,pauth=off > > > Output: qemu-system-aarch64: Could not open > > > '/var/home/berrange/.cache/ qemu/ > > > download/44cdbae275ef1bb6dab1d5fbb59473d4f741e1c8ea8a80fd9e906b531d6ad461': > > > Permission denied > > > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > > --- > > > tests/functional/qemu_test/asset.py | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > Reviewed-by: Thomas Huth <th...@redhat.com> > > Tested-by: Thomas Huth <th...@redhat.com> > > Actually, if you start with a clean cache, or if you manually do: > > chmod a-w ~/.cache/qemu/download/* > > a couple of tests are failing now. Could you please have a look?
Oooh, I thought I tested with all targets enabled, but I guess I must have missed something. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
